Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeCAD reference on docs #575

Closed
RubenRubens opened this issue Jan 12, 2021 · 4 comments
Closed

FreeCAD reference on docs #575

RubenRubens opened this issue Jan 12, 2021 · 4 comments
Labels

Comments

@RubenRubens
Copy link
Contributor

RubenRubens commented Jan 12, 2021

Read the docs 📖:

cadquery/cadquery/cq.py

Lines 404 to 412 in ccf56e6

def toOCC(self) -> Any:
"""
Directly returns the wrapped FreeCAD object to cut down on the amount of boiler plate code
needed when rendering a model in FreeCAD's 3D view.
:return: The wrapped FreeCAD object
:rtype A FreeCAD object or a SolidReference
"""
return self.val().wrapped

I have no idea what this one does. There are other 13 references in cadquery/cq.py about FreeCAD.

@jmwright
Copy link
Member

The doc string was apparently never updated from when CQ was built on top of FreeCAD. In CQ 2.0 it returns the underlying OCCT object.

@jmwright
Copy link
Member

I guess more accurately, that method used to be called toFreecad() and the doc string never got updated.

@adam-urbanczyk
Copy link
Member

I'll amend it in #573

@adam-urbanczyk
Copy link
Member

Solved in #573.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants