Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findSolid errors #655

Merged
merged 6 commits into from
Mar 3, 2021
Merged

findSolid errors #655

merged 6 commits into from
Mar 3, 2021

Commits on Feb 24, 2021

  1. findSolid returns None when no solids found 

    Removed a line in the findSolid docstring about raising an error if no
solids found. Added exceptions to several methods that were previously
failing with AttributeErrors when they tried to treat the None object as
a solid.
    @marcus7070
    marcus7070 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    b66d7c9 View commit details
    Browse the repository at this point in the history

  2. findSolid needed type hint Optional on it's return value

    @marcus7070
    marcus7070 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    f36eab8 View commit details
    Browse the repository at this point in the history

  3. Type hint and test Workplane.findFace

    @marcus7070
    marcus7070 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    b3c4e39 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Rewrite to raise ValueError in findSolid

    @marcus7070
    marcus7070 committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    4df7eec View commit details
    Browse the repository at this point in the history

  2. I forgot about findFace again

    @marcus7070
    marcus7070 committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    3ae2ef1 View commit details
    Browse the repository at this point in the history

  3. add exceptions to docstrings

    @marcus7070
    marcus7070 committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    d711a81 View commit details
    Browse the repository at this point in the history