Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for new extrude capabilities #894

Merged
merged 11 commits into from
Oct 30, 2021

Conversation

Jojain
Copy link
Contributor

@Jojain Jojain commented Sep 30, 2021

Added examples for extrude and cutblind until extrusion parameter

Updated weird leftover text in Example page

Added examples for extrude and cutblind until extrusion parameter

Updated weird leftover text in Example page
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #894 (bc6bf9e) into master (f19c35c) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   95.91%   95.94%   +0.02%     
==========================================
  Files          32       32              
  Lines        7817     7825       +8     
  Branches      846      846              
==========================================
+ Hits         7498     7508      +10     
+ Misses        186      184       -2     
  Partials      133      133              
Impacted Files Coverage Δ
cadquery/cq.py 91.49% <ø> (+0.09%) ⬆️
cadquery/selectors.py 98.12% <ø> (-0.02%) ⬇️
tests/test_cadquery.py 99.24% <0.00%> (+<0.01%) ⬆️
cadquery/cqgi.py 79.50% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19c35c...bc6bf9e. Read the comment docs.

@Jojain
Copy link
Contributor Author

Jojain commented Oct 2, 2021

I also added a note for revolve has I got confused recently of the relative axis behaviour

@adam-urbanczyk @marcus7070 @jmwright
This is ready for review.

I'm not too sure about the "skyscrappers" example, I wanted to expose a bit more of advanced operations as well as the cutBlind example, but I'm not sure it's a good example. Let me know if you want it changed/removed.

The tests has failed due to :

..\_test_env\lib\site-packages\vtkmodules\all.py:50: in <module>
    from .vtkIONetCDF import *
E   ImportError: DLL load failed while importing vtkIONetCDF: The specified procedure could not be found.

I don't know how my change would impact this but, even with a retrigger of CI it's failing at the same place

@marcus7070 marcus7070 self-requested a review October 19, 2021 10:35
Copy link
Member

@marcus7070 marcus7070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jojain!

* * Change pyparsing usage to be compatible with version 3

    upcaseTokens -> pyparsing_common.upcaseTokens

* Spec minimum pyparsing in the conda package

* syntax fix

Co-authored-by: AU <adam-urbanczyk@users.noreply.github.com>
@marcus7070 marcus7070 merged commit aba24c0 into CadQuery:master Oct 30, 2021
@lorenzncode
Copy link
Member

@Jojain May I suggest a small typo change? I think you are going for "skyscraper" not a crapper in the sky lol.

skycrappers->skyscrapers

https://en.wiktionary.org/wiki/skyscraper
https://en.wiktionary.org/wiki/crapper

A few other minor typos:
"the algorithm in charge of finding the candidates faces do it’s search by counting"
->
"the algorithm in charge of finding the candidate faces does its search by counting"

"where extruding and cuting"
->
"where extruding and cutting"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants