-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docs for new extrude capabilities #894
Conversation
Added examples for extrude and cutblind until extrusion parameter Updated weird leftover text in Example page
Codecov Report
@@ Coverage Diff @@
## master #894 +/- ##
==========================================
+ Coverage 95.91% 95.94% +0.02%
==========================================
Files 32 32
Lines 7817 7825 +8
Branches 846 846
==========================================
+ Hits 7498 7508 +10
+ Misses 186 184 -2
Partials 133 133
Continue to review full report at Codecov.
|
I also added a note for @adam-urbanczyk @marcus7070 @jmwright I'm not too sure about the "skyscrappers" example, I wanted to expose a bit more of advanced operations as well as the The tests has failed due to :
I don't know how my change would impact this but, even with a retrigger of CI it's failing at the same place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jojain!
* * Change pyparsing usage to be compatible with version 3 upcaseTokens -> pyparsing_common.upcaseTokens * Spec minimum pyparsing in the conda package * syntax fix Co-authored-by: AU <adam-urbanczyk@users.noreply.github.com>
@Jojain May I suggest a small typo change? I think you are going for "skyscraper" not a crapper in the sky lol. skycrappers->skyscrapers https://en.wiktionary.org/wiki/skyscraper A few other minor typos: "where extruding and cuting" |
Added examples for extrude and cutblind until extrusion parameter
Updated weird leftover text in Example page