Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid selection of runs with different granularity and epoch length #145

Open
thinkh opened this issue May 4, 2018 · 3 comments
Open

Avoid selection of runs with different granularity and epoch length #145

thinkh opened this issue May 4, 2018 · 3 comments

Comments

@thinkh
Copy link
Member

thinkh commented May 4, 2018

With the revised timeline layout #126 using a single timeline, we introduced the following constraints:

  • All runs have same epoch length
  • The granularity of all runs is equal

To meet this requirements we have to extend the run selector. After the user selects the first run all incompatible runs (i.e., different epoch length and granularity) are disabled in the selector. This way we prevent mixing incompatible runs.

@NMO13
Copy link
Contributor

NMO13 commented May 13, 2018

I don't think we have to check these requirements in malevo. I would say that this is a data requirement that the provider of the runs has to meet.

@gfrogat
Copy link
Contributor

gfrogat commented May 13, 2018

Malevo should only show all the relevant runs which can be compared. It's a simple filtering functionality that avoids errors due to incompatible granularities. If we don't want the user to encounter this type of error we simply only show compatible runs in the selection window.

Maybe you have a better idea how to solve this but we should not require the user to handle this.

@mstreit
Copy link
Member

mstreit commented May 13, 2018

I think the solution to filter the runs based on the first selection is simple and effective. This way we can handle multiple compatible run sets in our interface without letting the user run into compatibility problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants