Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #15

Merged
merged 7 commits into from
Jan 12, 2023
Merged

Update deps #15

merged 7 commits into from
Jan 12, 2023

Conversation

keckelt
Copy link
Member

@keckelt keckelt commented Oct 4, 2022

Summary of changes

  • update git dependencies so that yarn is happy
  • move RouterScrollToTop here from coral as it is used by the welcome page
  • move canvas-confetti here from coral as it is used by the welcome page
  • remove yarn.lock

Additional notes for the reviewer(s)

In tandem with Caleydo/coral#47

@keckelt
Copy link
Member Author

keckelt commented Oct 4, 2022

Todo: revert 695a56a after merging Caleydo/coral#47

package.json Outdated
"coral": "git+ssh://git@github.com:Caleydo/coral#develop",
"ordino": "git+ssh://git@github.com:Caleydo/ordino#develop",
"canvas-confetti": "^1.4.0",
"coral": "git+ssh://git@github.com/Caleydo/coral#dev_d3_merge_fix",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that not be the develop branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but it does not build when referencing develop

therefore the comment: #15 (comment) ;-)

@keckelt keckelt mentioned this pull request Oct 6, 2022
17 tasks
@keckelt keckelt merged commit 269f25b into develop Jan 12, 2023
@keckelt keckelt deleted the update_deps branch January 12, 2023 10:37
@dvvanessastoiber dvvanessastoiber mentioned this pull request Feb 13, 2023
2 tasks
dvvanessastoiber added a commit that referenced this pull request Feb 13, 2023
* prepare next dev version

* Prepare github changes

* Update README.md

* Remove circleci

* prepare next dev version

* Update fontawesome

* Merge visyn_scripts

* Update deps (#15)

* remove outdated yarn.lock

* reformat git dependencies

* add RouterScrollToTop to coral public

* add canvas-confetti dependency

* format coda

* temporary switch coral branch  to dev_d3_merge_fix

* Revert "temporary switch coral branch  to dev_d3_merge_fix"

This reverts commit 695a56a.

* prepare relase 3.2.0

---------

Co-authored-by: anita-steiner <>
Co-authored-by: Anita Steiner <anita.steiner@datavisyn.io>
Co-authored-by: Klaus Eckelt <Klaus.Eckelt@jku.at>
@thinkh thinkh mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants