Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set fixed height for header #3

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Set fixed height for header #3

merged 1 commit into from
Feb 10, 2022

Conversation

keckelt
Copy link
Member

@keckelt keckelt commented Feb 10, 2022 •
edited
Loading

Added a fixed height to avoid flickering when switching tabs.
Note: Only applies when the screen > 992 px. When screen < 992 px the header tabs collapse and the height is variable and depends on the tabs

based on Caleydo/ordino#356
same as https://github.com/Caleydo/cohort/pull/659

@keckelt keckelt self-assigned this Feb 10, 2022
@keckelt keckelt added release: patch PR merge results in a new patch version type: bug Something isn't working labels Feb 10, 2022
PatrickAdelberger
PatrickAdelberger approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@PatrickAdelberger PatrickAdelberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@keckelt keckelt merged commit 1513bc0 into main Feb 10, 2022
@keckelt keckelt deleted the header_flickering branch February 10, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickAdelberger PatrickAdelberger PatrickAdelberger approved these changes

Assignees

@keckelt keckelt

Labels
release: patch PR merge results in a new patch version type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keckelt @PatrickAdelberger