Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Fix KeyError in diff_finder.py #18

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Fix KeyError in diff_finder.py #18

merged 2 commits into from
Oct 31, 2019

Conversation

dvvanessastoiber
Copy link
Contributor

Fixes #17 :

json_obj['content'] is None

results in KeyError. It can be fixed by checking, whether content exists in the list of keys that occur in the object.

thinkh
thinkh approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Looks good!

@thinkh thinkh merged commit d9e28a7 into develop Oct 31, 2019
@thinkh thinkh deleted the stoiber/17_KeyError_in_diff_finder branch October 31, 2019 12:33
@thinkh thinkh changed the title Fix KeyError in _diff_finder.py_ Fix KeyError in diff_finder.py Oct 31, 2019
@thinkh thinkh changed the title Fix KeyError in diff_finder.py Fix KeyError in diff_finder.py Oct 31, 2019
@thinkh thinkh mentioned this pull request Jan 16, 2020
Merged
28 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvvanessastoiber @thinkh