Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Replace gene_map_ensgs API requests with native idtype mapping #168

Merged

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Jun 21, 2022

Requires Caleydo/tdp_publicdb#189

Closes Caleydo/tdp_bi_bioinfodb#419

  • Remove _id from typing, as it was not returned by the API and was not used previously

Closes Caleydo/tdp_bi_bioinfodb#419

* Remove `_id` from typing, as it was not returned by the API and was not used previously
@thinkh thinkh added type: refactor Refactor the current implementation release: patch PR merge results in a new patch version labels Jun 21, 2022
@thinkh thinkh requested a review from oltionchampari June 21, 2022 09:26
Copy link
Contributor

@oltionchampari oltionchampari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it is not used anywhere else. Looks good.

@oltionchampari oltionchampari merged commit 1050aca into develop Jun 21, 2022
@thinkh thinkh deleted the thinkh/419_replace-gene_map_ensg-with-native-mapping branch June 21, 2022 11:14
@dvvanessastoiber dvvanessastoiber mentioned this pull request Aug 4, 2022
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release: patch PR merge results in a new patch version type: refactor Refactor the current implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants