-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-input example #94
Conversation
I'm conscious that the weights are a binary and fairly large (3.0M). |
66fedb0
to
3cf8617
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Have left a couple of comments for minor changes.
# trace_to_torchscript(trained_model, trained_model_dummy_input, filename=saved_ts_filename) | ||
|
||
# Load torchscript and run model as a test | ||
testing_input_u = 2.0 * trained_model_dummy_input_u |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a line to why the input is scaled by a factor of 2
@@ -0,0 +1,136 @@ | |||
"""Load a pytorch model and convert it to TorchScript.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could mention the methods included for torchscript conversion here (tracing and scripting), and that scripting
is the recommended method
@@ -0,0 +1,2 @@ | |||
torch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding minimum required versions would be good?
p_surf : | ||
surface pressure (128, num_col) | ||
Y_out : | ||
output prellocated in MiMA (128, num_col, 40) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling of prelocated
I am closing this as we now have other examples (e.g. MultiIO) in the examples suite that demonstrate this property, and this was using the old API anyway. |
Closes #13