chore: More locations where a deferred saves oodles of execution time

CandoImage · Jul 14, 2023 · 62bedea · 62bedea
1 parent c2e8988
commit 62bedea
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/src/GraphQL/Resolver/AssetType.php b/src/GraphQL/Resolver/AssetType.php
@@ -211,9 +211,7 @@ public function resolveSrcSet($value = null, $args = [], $context = [], ResolveI
  if (!$resolveInfo || $resolveInfo->fieldName !== 'data') {
  $deferredThumbnail = true;
  }
- //@TODO: check if we can use the $deferredThumbnail variable with the new method too
- // $thumbnail = $asset->getThumbnail($args['thumbnail'], $deferredThumbnail);
- $thumbnail = $assetFieldHelper->getAssetThumbnail($asset, $thumbNailConfig, $thumbNailFormat);
+ $thumbnail = $assetFieldHelper->getAssetThumbnail($asset, $thumbNailConfig, $thumbNailFormat, $deferredThumbnail);
  $thumbnailConfig = $asset->getThumbnailConfig($args['thumbnail']);
  if ($thumbnailConfig) {
  foreach ($thumbnailConfig->getMedias() as $key => $val) {
@@ -293,19 +291,15 @@ public function resolveResolutions($value = null, $args = [], $context = [], Res
  if (!$asset) {
  return [];
  }
- //@TODO: check if we can use the $deferredThumbnail variable with the new method too
- // before we had: $thumbnail = $asset->getThumbnail($thumbnailName, $deferredThumbnail);
- $thumbnail = $assetFieldHelper->getAssetThumbnail($asset, $thumbnailName, $thumbnailFormat);
+ $thumbnail = $assetFieldHelper->getAssetThumbnail($asset, $thumbnailName, $thumbnailFormat, $deferredThumbnail);
  if (isset($thumbnail)) {
  $thumbnailConfig = $thumbnail->getConfig();
  foreach ($types as $type) {
  $thumbConfigRes = clone $thumbnailConfig;
  $thumbConfigRes->setHighResolution($type);
  $thumbConfigRes->setMedias([]);
  $resolutions[] = [
- //@TODO: check if we can use the $deferredThumbnail variable with the new method too
- // $asset->getThumbnail($thumbConfigRes, $deferredThumbnail),
- 'url' => $assetFieldHelper->getAssetThumbnail($asset, $thumbConfigRes, $thumbnailFormat),
+ 'url' => $assetFieldHelper->getAssetThumbnail($asset, $thumbConfigRes, $thumbnailFormat, $deferredThumbnail),
  'resolution' => $type,
  ];
  }