This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
Upgrade dependencies to latest versions and fixed breaking changes. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 10 is supported for a while now by grpc. Firebase 5.x incorporates that jump; nothing changed in regards to APIs for `apollo-link-firebase` but without this fix, it will always pull in a second version of firebase which will fail on Node 10.
D1no
added a commit
to D1no/fightback
that referenced
this pull request
Apr 23, 2019
Directive typing could be improved in the future by using apollo-utilities types instead of the constructed DirectiveArgs. That would require a refactor.
D1no
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 10 is supported for a while now by grpc. Firebase 5.x incorporates that jump; nothing changed in regards to APIs for
apollo-link-firebasebut without this fix, it will always pull in a second version of firebase which will fail on Node 10.