-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate initial gas property in python example ic_engine.py #1460
Comments
Thanks for reporting this! Despite appearances, I believe this is intended. The reason is that in principle, the reservoir can have a different state than the reactor (cylinder). As such, we are demonstrating that you can set those values before creating the reservoir, even on the same object, without changing the reactor. However, a note to that effect is probably warranted! Thanks |
Thanks for responding. Yes, it makes sense. Should I close the issue? |
No, I think we can leave it open, with the fix being a comment describing what's going on. If you'd like to open a pull request with the change, please feel free! |
Gas properties are defined 2 times in ic_engine.py
This is just a documentation issue.
Line
gas.TPX = T_inlet, p_inlet, comp_inlet
is duplicated:Suggest to remove duplicate.
The text was updated successfully, but these errors were encountered: