feat: Canto v8 #129
Merged
feat: Canto v8 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudong2
changed the title
Co-authored-by: Sujong Lee <leesj9476lsj@gmail.com>
feat. simulation codes for canto modules
feat: bump up cosmos-sdk v0.50.8, cometbft v0.38.9, ibc-go v8.3.2
* fix: wrong denom check at RegisterCoin problem: - `coinMetadata.Base` is used as the denom for the token pair - However, the check is incorrectly performed using `coinMetadata.Name`, so it fails to detect if the denom is already registered solution: check using `coinMetadata.Base`, not `.Name` more context: Unfortunately, there is already one case on the mainnet where multiple token pairs exist for the same denom(= ibc/13B6057538B93225F6EBACCB64574C49B2C1568C5AE6CCFE0A039D7DAC02BF29). However, this is not a major issue because only the latest token pair registered in the denom index is actually used. With this patch, such cases will no longer occur. * chore: recover missing test codes and refactoring
feat: wait-tx query cmd
feat: Bump up ethermint v0.22.0-sdk50-1
* add tc for working hash of modules * chore: fix comment * chore: add comment remove un-necessary comment * chore: format imports
fix: v8 upgrade handler
|
@tkkwon1998 Can you review this PR? |
chore: Update swagger docs
|
@tkkwon1998 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Key dependency changes:
remained tasks
The above 2 tasks must be completed before release.
notable changed files
app
modules
ValidateBasiclogic to msg_serverprotobuf. But in case ofMsgConvertERC20, GetSigners func is alive and implemented GetSignersFromMsgConvertERC20V2 func additionally.(ref. feat: bump up cosmos-sdk v0.50.x, cometbft v0.38.x b-harvest/Canto#53 (comment))msg levelsoauthorityhas been added to the required module.(ref. Add CLI command to submit new Gov proposals, using Msgs cosmos/cosmos-sdk#10952)KVStoreServiceas opposed to the prev way of accessing KVStore via store key.(ref. refactor(x/staking)!: KVStoreService, return errors and use context.Context cosmos/cosmos-sdk#16324, ...)Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...