Skip to content

Commit 067b72b

Browse files
committed
Coderabbit suggestions
1 parent 4d4284f commit 067b72b

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

crates/enc-ffmpeg/src/video/h264.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -333,8 +333,9 @@ fn get_codec_and_options(
333333

334334
fn get_bitrate(width: u32, height: u32, frame_rate: f32, bpp: f32) -> usize {
335335
// higher frame rates don't really need double the bitrate lets be real
336-
let frame_rate_multiplier = (frame_rate - 30.0).max(0.0) * 0.6 + 30.0;
337-
let pixels_per_second = (width * height) as f32 * frame_rate_multiplier;
336+
let frame_rate_multiplier = ((frame_rate as f64 - 30.0).max(0.0) * 0.6) + 30.0;
337+
let area = (width as f64) * (height as f64);
338+
let pixels_per_second = area * frame_rate_multiplier;
338339

339-
(pixels_per_second * bpp) as usize
340+
(pixels_per_second * bpp as f64) as usize
340341
}

0 commit comments

Comments
 (0)