From d91d1adae0ebc32be62bbd1525cdf1912e5aaeb5 Mon Sep 17 00:00:00 2001 From: Carlos Rodriguez Date: Mon, 2 May 2022 10:31:50 +0200 Subject: [PATCH] add validation of packet ID in CLI to query packet (#1314) --- modules/apps/29-fee/client/cli/query.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/modules/apps/29-fee/client/cli/query.go b/modules/apps/29-fee/client/cli/query.go index 4da82704fb0..092b7441453 100644 --- a/modules/apps/29-fee/client/cli/query.go +++ b/modules/apps/29-fee/client/cli/query.go @@ -20,22 +20,23 @@ func GetCmdIncentivizedPacket() *cobra.Command { Short: "Query for an unrelayed incentivized packet by port-id, channel-id and packet sequence.", Long: "Query for an unrelayed incentivized packet by port-id, channel-id and packet sequence.", Args: cobra.ExactArgs(3), - Example: fmt.Sprintf("%s query ibc-fee packet-by-id", version.AppName), + Example: fmt.Sprintf("%s query ibc-fee packet", version.AppName), RunE: func(cmd *cobra.Command, args []string) error { clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } + portID, channelID := args[0], args[1] seq, err := strconv.ParseUint(args[2], 10, 64) if err != nil { return err } - packetID := channeltypes.PacketId{ - PortId: args[0], - ChannelId: args[1], - Sequence: seq, + packetID := channeltypes.NewPacketId(portID, channelID, seq) + + if err := packetID.Validate(); err != nil { + return err } req := &types.QueryIncentivizedPacketRequest{