Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditIgnores - Content is only saved when touching another option #140

Closed
Catfriend1 opened this issue Dec 16, 2018 · 1 comment
Closed

EditIgnores - Content is only saved when touching another option #140

Catfriend1 opened this issue Dec 16, 2018 · 1 comment
Assignees
@Catfriend1
Labels
bug
Milestone
1.0.1

Comments

@Catfriend1
Copy link
Owner

EditIgnores - Content is only saved when touching another option before exiting the folder EditIgnores dialog.

Description of the issue

Details: See #19

Reproducer

Reported by @gradha https://imgur.com/a/l3c0jac

id look at the ignore patterns option, but I don't know how to save the state. When I touch the line it shows an inline editor, but it seems that it goes off screen, so after typing I can only press back, which doesn't seem to save the contents (when I go inside again the editor field is blank). See screenshot: (...) Indeed, the trick is to touch another option, then it is saved. Tricky.

Version Information

App Version: 0.14.51+
@Catfriend1 Catfriend1 added the bug label Dec 16, 2018
@Catfriend1 Catfriend1 added this to the 0.14.55 milestone Dec 16, 2018
@Catfriend1 Catfriend1 self-assigned this Dec 16, 2018
Catfriend1 added a commit that referenced this issue Dec 18, 2018
@Catfriend1
Fix NPE after config regeneration (fixes #140)
88d2226
@Catfriend1 Catfriend1 reopened this Dec 22, 2018
@Catfriend1 Catfriend1 modified the milestones: 1.0.0, 1.0.1 Jan 1, 2019
Catfriend1 added a commit that referenced this issue Jan 1, 2019
@Catfriend1
Save ignore list reliably when returning from edit folder dialog (fixes
c798113 
#140)
@Catfriend1 Catfriend1 mentioned this issue Jan 1, 2019
Merged
Catfriend1 added a commit that referenced this issue Jan 1, 2019
@Catfriend1
Do not return on empty ignore list (fixes #140)
3de3bcb
@Catfriend1
Copy link
Owner Author

The fix will be part of an upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Catfriend1 Catfriend1

Labels
bug
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
1 participant
@Catfriend1