Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Use GHA workflow for a quick feedback #82

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Use GHA workflow for a quick feedback #82

merged 1 commit into from
Dec 5, 2023

Conversation

lmilbaum
Copy link
Contributor

@lmilbaum lmilbaum commented Dec 3, 2023

No description provided.

@lmilbaum lmilbaum self-assigned this Dec 3, 2023
cgwalters
cgwalters approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this but we should debate whether it still makes sense to keep this as a cheap "test build the container on x86_64 on pull requests".

I think I'd vote to keep the workflow file for now at least, but only trigger it on workflow_dispatch perhaps and drop the pushes.

But, dunno. The file will always be there in the git history too, so if you prefer to go all in on RHTAP even for PR testing, that's good by me and we can merge this as is.

@lmilbaum
Copy link
Contributor Author

lmilbaum commented Dec 4, 2023

I'm OK with this but we should debate whether it still makes sense to keep this as a cheap "test build the container on x86_64 on pull requests".

I think I'd vote to keep the workflow file for now at least, but only trigger it on workflow_dispatch perhaps and drop the pushes.

But, dunno. The file will always be there in the git history too, so if you prefer to go all in on RHTAP even for PR testing, that's good by me and we can merge this as is.

Your argument makes sense. I'll update the PR.

@lmilbaum lmilbaum changed the title Drop GitHub Actions pipeline Use GHA workflow for a quick feedback Dec 4, 2023
@lmilbaum lmilbaum requested a review from cgwalters December 4, 2023 04:47
@lmilbaum lmilbaum requested a review from vrothberg December 4, 2023 09:28
vrothberg
vrothberg approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmilbaum
Copy link
Contributor Author

lmilbaum commented Dec 4, 2023

Switching the PR to draft because RHTAP doesn't release the centos-bootc image yet.

@lmilbaum lmilbaum marked this pull request as draft December 4, 2023 09:42
@lmilbaum lmilbaum changed the title Use GHA workflow for a quick feedback DO NOT MERGE - Use GHA workflow for a quick feedback Dec 4, 2023
@lmilbaum lmilbaum changed the title DO NOT MERGE - Use GHA workflow for a quick feedback Use GHA workflow for a quick feedback Dec 5, 2023
@lmilbaum lmilbaum marked this pull request as ready for review December 5, 2023 04:42
@lmilbaum
Copy link
Contributor Author

lmilbaum commented Dec 5, 2023

Switching the PR to draft because RHTAP doesn't release the centos-bootc image yet

RHTAP release pipelines updated. Merging.

@lmilbaum lmilbaum merged commit ad06860 into CentOS:main Dec 5, 2023
4 checks passed
@lmilbaum lmilbaum deleted the cleanup branch December 5, 2023 04:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg approved these changes

@cgwalters cgwalters cgwalters approved these changes

Assignees

@lmilbaum lmilbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmilbaum @cgwalters @vrothberg