From 4ee18c94d4969a49b81b726260a093f3fd201070 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Sun, 22 Dec 2019 20:39:17 +0100 Subject: [PATCH 1/3] Clean up E0124 explanation --- src/librustc_error_codes/error_codes/E0124.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/librustc_error_codes/error_codes/E0124.md b/src/librustc_error_codes/error_codes/E0124.md index a7836526a7dd4..f08f7e9800551 100644 --- a/src/librustc_error_codes/error_codes/E0124.md +++ b/src/librustc_error_codes/error_codes/E0124.md @@ -1,5 +1,6 @@ -You declared two fields of a struct with the same name. Erroneous code -example: +A struct with two fields having the same name has been declared. + +Erroneous code example: ```compile_fail,E0124 struct Foo { From 1474d2a41a32f7f969c7d924ea917a1390ebe1c6 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Sun, 22 Dec 2019 20:39:25 +0100 Subject: [PATCH 2/3] Clean up E0128 explanation --- src/librustc_error_codes/error_codes/E0128.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/librustc_error_codes/error_codes/E0128.md b/src/librustc_error_codes/error_codes/E0128.md index d0a4b32f9688e..6f8dfe3a73b9e 100644 --- a/src/librustc_error_codes/error_codes/E0128.md +++ b/src/librustc_error_codes/error_codes/E0128.md @@ -1,4 +1,5 @@ -Type parameter defaults can only use parameters that occur before them. +A type parameter with default value is using forward declared identifier. + Erroneous code example: ```compile_fail,E0128 @@ -7,11 +8,11 @@ struct Foo { field2: U, } // error: type parameters with a default cannot use forward declared -// identifiers +// identifiers ``` -Since type parameters are evaluated in-order, you may be able to fix this issue -by doing: +Type parameter defaults can only use parameters that occur before them. Since +type parameters are evaluated in-order, this issue could be fixed by doing: ``` struct Foo { From 256eec4ae0653e35cdd39261a2b59d69c91b1a71 Mon Sep 17 00:00:00 2001 From: Dylan DPC Date: Mon, 23 Dec 2019 12:55:33 +0530 Subject: [PATCH 3/3] Update E0124.md --- src/librustc_error_codes/error_codes/E0124.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/librustc_error_codes/error_codes/E0124.md b/src/librustc_error_codes/error_codes/E0124.md index f08f7e9800551..8af7cb819cfaf 100644 --- a/src/librustc_error_codes/error_codes/E0124.md +++ b/src/librustc_error_codes/error_codes/E0124.md @@ -1,4 +1,4 @@ -A struct with two fields having the same name has been declared. +A struct was declared with two fields having the same name. Erroneous code example: