Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return RunFailed error #16

Closed
chunshao90 opened this issue Dec 29, 2022 · 0 comments · Fixed by #17
Closed

Return RunFailed error #16

chunshao90 opened this issue Dec 29, 2022 · 0 comments · Fixed by #17
Assignees
Labels
bug Something isn't working

Comments

@chunshao90
Copy link
Member

Describe this problem

When cases fail to run, sqlness return 0as the result which means success.
run_env needs to return errors up instead of logging.
Refer to

if let Err(e) = self.run_env(&env, &db).await {
.

Steps to reproduce

  1. Define a wrong case, run sqlness.
  2. echo $? will return 0 while the correct result should be 1.

Expected behavior

No response

Additional Information

No response

@chunshao90 chunshao90 added the bug Something isn't working label Dec 29, 2022
@waynexia waynexia self-assigned this Dec 29, 2022
@waynexia waynexia assigned jiacai2050 and unassigned waynexia Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants