CERT 7009 Add Chronicle Price Feed #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ertora/Quorum into niv/CERT-7009-Add-Chronicle-Price-Feed
liav-certora
approved these changes
Nov 5, 2024
| def __init__(self): | ||
| self.session = requests.Session() | ||
| self.memory = defaultdict(list) | ||
| self.info_url = "https://chroniclelabs.org/api/median/info/{}/{}/?testnet=false" |
There was a problem hiding this comment.
I think either define this url in get_price_feeds_info or define the url from __process_pairs here. It looks funky that you treat urls differently.
Quorum/checks/feed_price.py
Outdated
| price_feeds = self.api.get_price_feeds_info(self.chain) | ||
| self.price_feeds_dict = {feed.contractAddress: feed for feed in price_feeds} | ||
| self.price_feeds_dict.update({feed.proxyAddress: feed for feed in price_feeds if feed.proxyAddress}) | ||
| price_feeds = self.chainlink_api.get_price_feeds_info(self.chain) |
There was a problem hiding this comment.
chainlink_price_feeds?
…ertora/Quorum into niv/CERT-7009-Add-Chronicle-Price-Feed
Comment on lines
23
to
25
| pairs = requests.get( | ||
| "https://chroniclelabs.org/api/pairs?testnet=false" | ||
| ).json() |
There was a problem hiding this comment.
Any retries or raise_for_status needed here?
There was a problem hiding this comment.
Thanks added raise_for_status
yoav-el-certora
approved these changes
Nov 5, 2024
…ertora/Quorum into niv/CERT-7009-Add-Chronicle-Price-Feed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 PR Summary: Integrate
ChronicleAPIand Enhance Feed Price Verification🔧 Key Changes:
Quorum/apis/price_feeds/__init__.py:ChainLinkAPIandChronicleAPIfor centralized access.__all__ = [ChainLinkAPI, ChronicleAPI]for clear API exposure.ChainLinkAPI:Quorum/apis/chainlink_api.pytoQuorum/apis/price_feeds/chainlink_api.pyfor better organization within theprice_feedspackage.git_api:Quorum/git_apitoQuorum/apis/git_apifor better organization.ChronicleAPI:Quorum/apis/price_feeds/chronicle_api.pyto interact with the Chronicle data feed API.ChronicleAPIas a singleton to efficiently manage API requests and cache price feed data.Feed Price Verification Enhancements:
Quorum/checks/feed_price.py:ChainLinkAPIandChronicleAPI: Adjusted import paths to the newprice_feedspackage.chainlink_api = ChainLinkAPI()chronicle_api = ChronicleAPI()Utility Updates:
Quorum/utils/chain_enum.py:SCR➔SCROLLZK➔ZKSYNC✅ Benefits:
ChronicleAPIalongsideChainLinkAPIallows the tool to verify price feeds against multiple authoritative sources, enhancing reliability.price_feedspackage promotes better maintainability and scalability.