Skip to content

Conversation

@jjspace
Copy link
Contributor

@jjspace jjspace commented Jun 30, 2025

Description

This is, by all means, not an ideal solution. Something, that I am unable to determine, is causing Firefox v140 to fail to load the imported bucket.css stylesheet. The network request just doesn't happen after constructing the stylesheet.

Adding a random space ( ) character somewhere in the style tag seems to make it work for whatever reason. I chose to automate this and add it after the @import rule we can expect to exist.

More details and discussion about investigation and attempts to reproduce is in #12700.

So far this does not seem to be an issue in the new version of Sandcastle (#12566) so this "hack" should only have to exist until that's done.

Issue number and link

Hack for #12700

Testing plan

  • Run npm start
  • Load Sandcastle locally in Firefox v140 and make sure it works
  • Make sure clicking "Open in new window" opens the standalone page and it still works
  • Verify Chrome and other browsers still work as well

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@github-actions
Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

Copy link
Contributor

@javagl javagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out and it seems to work. But I'm still stumped about what might be the reason for all that.

@ggetz
Copy link
Contributor

ggetz commented Jul 1, 2025

Thanks for the fix @jjspace! Given we want a fix for today's release and the overall intention is to replace the current Sandcastle app code, this hack will be sufficient.

@ggetz ggetz added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit 1bafc49 Jul 1, 2025
9 checks passed
@ggetz ggetz deleted the sandcastle-ff-hack branch July 1, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants