From a4f80fe5cd4151aa0562fcf5fd361e23b52fd515 Mon Sep 17 00:00:00 2001 From: dapplion <35266934+dapplion@users.noreply.github.com> Date: Tue, 14 Feb 2023 13:04:44 +0800 Subject: [PATCH 1/2] Add peer id str to mismatch error --- src/utils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils.ts b/src/utils.ts index 6eadfce7..b4e09ba9 100644 --- a/src/utils.ts +++ b/src/utils.ts @@ -75,7 +75,7 @@ export async function verifySignedPayload ( // Unmarshaling from PublicKey protobuf const payloadPeerId = await peerIdFromKeys(payload.identityKey) if (!payloadPeerId.equals(remotePeer)) { - throw new Error("Peer ID doesn't match libp2p public key.") + throw new Error(`Payload identity key ${payloadPeerId.toString()} does not match expected remote peer ${remotePeer.toString()}`) } const generatedPayload = getHandshakePayload(noiseStaticKey) From 7fdde28312205d3966c0e6cefb67e3531a15ff8f Mon Sep 17 00:00:00 2001 From: dapplion <35266934+dapplion@users.noreply.github.com> Date: Mon, 20 Feb 2023 16:47:22 +0800 Subject: [PATCH 2/2] Update error messages --- test/xx-handshake.spec.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/xx-handshake.spec.ts b/test/xx-handshake.spec.ts index 5cfeab9f..16e8b740 100644 --- a/test/xx-handshake.spec.ts +++ b/test/xx-handshake.spec.ts @@ -88,7 +88,7 @@ describe('XX Handshake', () => { assert(false, 'Should throw exception') } catch (e) { const err = e as Error - expect(err.message).equals("Error occurred while verifying signed payload: Peer ID doesn't match libp2p public key.") + expect(err.message).equals(`Error occurred while verifying signed payload: Payload identity key ${peerB.toString()} does not match expected remote peer ${fakePeer.toString()}`) } }) @@ -120,7 +120,7 @@ describe('XX Handshake', () => { assert(false, 'Should throw exception') } catch (e) { const err = e as Error - expect(err.message).equals("Error occurred while verifying signed payload: Peer ID doesn't match libp2p public key.") + expect(err.message).equals(`Error occurred while verifying signed payload: Payload identity key ${peerA.toString()} does not match expected remote peer ${fakePeer.toString()}`) } }) })