diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index bd802e83bc69..b5fa586c7a8b 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -17,6 +17,7 @@ on: branches: - stable - unstable + workflow_dispatch: jobs: run: diff --git a/packages/beacon-node/test/perf/chain/produceBlock/produceBlockBody.test.ts b/packages/beacon-node/test/perf/chain/produceBlock/produceBlockBody.test.ts index 1892281cfe7c..dbe86c2c5868 100644 --- a/packages/beacon-node/test/perf/chain/produceBlock/produceBlockBody.test.ts +++ b/packages/beacon-node/test/perf/chain/produceBlock/produceBlockBody.test.ts @@ -15,10 +15,9 @@ import {BeaconDb} from "../../../../src/index.js"; import {testLogger} from "../../../utils/logger.js"; const logger = testLogger(); -const numberOfValidators = 1024; describe("produceBlockBody", () => { - const stateOg = generatePerfTestCachedStateAltair({goBackOneSlot: false, vc: numberOfValidators}); + const stateOg = generatePerfTestCachedStateAltair({goBackOneSlot: false}); let db: BeaconDb; let chain: BeaconChain; diff --git a/packages/state-transition/test/perf/util.ts b/packages/state-transition/test/perf/util.ts index 46faf11c50f1..4df6746ea938 100644 --- a/packages/state-transition/test/perf/util.ts +++ b/packages/state-transition/test/perf/util.ts @@ -211,6 +211,10 @@ export function cachedStateAltairPopulateCaches(state: CachedBeaconStateAltair): state.inactivityScores.getAll(); } +/** + * Warning: This function has side effects on the cached state + * The order in which the caches are populated is important and can cause stable tests to fail. + */ export function generatePerfTestCachedStateAltair(opts?: { goBackOneSlot: boolean; vc?: number;