Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make State Cache Pruning Smarter #2154

Closed
wemeetagain opened this issue Mar 9, 2021 · 1 comment
Closed

Make State Cache Pruning Smarter #2154

wemeetagain opened this issue Mar 9, 2021 · 1 comment
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance. scope-security Issues that fix security issues: DOS, key leak, CVEs.

Comments

@wemeetagain
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently, the pruning of the state caches is very basic, controlled by calling cache.prune on regular regular intervals, when the chain processes a checkpoint. This naive strategy leads to more memory use than is needed.

When the chain is healthy, or when chain regen is low, we may need fewer states cached.
When the chain is unhealthy, or when more states are being requested, we may need more states cached.

Describe the solution you'd like

Implement a chain-level state manager that more intelligently manages the state cache pruning.
First steps would include mapping out a coherent strategy that would take into account both healthy and unhealthy chain conditions.

Describe alternatives you've considered

Maintain status quo.

Additional context

See #2152 #2153

@dapplion dapplion self-assigned this Mar 9, 2021
@dapplion dapplion added scope-performance Performance issue and ideas to improve performance. prio-high Resolve issues as soon as possible. labels Jun 11, 2021
@dapplion dapplion removed their assignment May 12, 2022
@dapplion dapplion added prio-medium Resolve this some time soon (tm). scope-security Issues that fix security issues: DOS, key leak, CVEs. and removed prio-high Resolve issues as soon as possible. labels Jun 29, 2022
@dapplion
Copy link
Contributor

Closing for a more general epic on #4005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance. scope-security Issues that fix security issues: DOS, key leak, CVEs.
Projects
None yet
Development

No branches or pull requests

2 participants