Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Eth-Consensus-Version" header absent in eth/v2/debug/beacon/states/{state_id} response #6123

Closed
jshufro opened this issue Nov 23, 2023 · 3 comments · Fixed by #6152
Closed
Labels
meta-bug Issues that identify a bug and require a fix.

Comments

@jshufro
Copy link
Contributor

jshufro commented Nov 23, 2023

Describe the bug

curl -H "Accept: application/octet-stream;q=1,application/json;q=0.9" -Ssv "http://consensus:5052/eth/v2/debug/beacon/states/finalized" > /dev/null                          
*   Trying 172.21.0.12:5052...
* Connected to consensus (172.21.0.12) port 5052
> GET /eth/v2/debug/beacon/states/finalized HTTP/1.1
> Host: consensus:5052
> User-Agent: curl/8.4.0
> Accept: application/octet-stream;q=1,application/json;q=0.9
> 
< HTTP/1.1 200 OK
< vary: Origin
< access-control-allow-origin: *
< content-type: application/octet-stream
< content-length: 213503710
< Date: Thu, 23 Nov 2023 04:46:56 GMT
< Connection: keep-alive
< Keep-Alive: timeout=72
< 
{ [14263 bytes data]
* Connection #0 to host consensus left intact

Expected behavior

Eth-Consensus-Version header should be set, as required by https://ethereum.github.io/beacon-APIs/#/Debug/getStateV2

image

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

v1.12.0

@jshufro jshufro added the meta-bug Issues that identify a bug and require a fix. label Nov 23, 2023
@nflaig
Copy link
Member

nflaig commented Nov 23, 2023

Did you face issues with that after updating the go http client? Same issue happens with the latest checkpointz version which also expects the Eth-Consensus-Version header to be set (#6124).

We are not following the spec here, this will be addressed by API rework done in #6080

@jshufro
Copy link
Contributor Author

jshufro commented Nov 23, 2023

Well, I was hitting this error, then I upgraded the attestantio http client so I could toggle the EnforceJson switch which sets Accept to exclude ssz, and then I hit the Invalid string length one.

I switched my holesky test environment to nimbus for now. Only 3300 validators were down while i migrated 😆

@nflaig
Copy link
Member

nflaig commented Dec 2, 2023

I switched my holesky test environment to nimbus for now. Only 3300 validators were down while i migrated 😆

Sorry to hear that, we have a fix ready for it and might already include that in a hotfix release. Our current API design is lacking a bit, with #6080 there will be a bunch of improvements and we will be able to verify that all headers required by spec are set correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants