Bump SSZ to v0.9.0 #3760
Merged
Bump SSZ to v0.9.0 #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a combination of 50 commits. Remove SSZ from params Update types in lodestar-api Replace .defaultValue() with .defaultValue Fix more types More type fixes Fix upgradeState functions Fix processDeposit pending logic Update test types f Update fork-choice types Update validator types WIP Lodestar changes WIP Lodestar Fix spec tests FIx more Lodestar types Fix proofs types Fix all type issues Use Uint64NumInf only where applicable Don't manipulate casing in loadYaml WIP Fix spec tests Fix build types Fix test types Update test types Fix getRandaoMix tests Review pickEth1Vote syncPubkeys in createFromState Fix unit tests Safe clone for CachedBeaconState Fix unit tests issues Fix genesis logic with ViewDU Fix all unit tests Fix processRewardsAndPenaltiesAllForks Commit state after processing Fix statusProcessEpoch Create valid pubkey cache in perf test Fix getDeposits for perf test Ensure CachedBeaconState clone is immutable Fix genesis spec tests Ensure stable commit in ViewDU Add advice on running spec tests Remove use of the type unsafe Number constructor Fix casing in spec test definitions Fix casing and bigint types in spec tests Advance epochCtx cached time units Add debug mode to fork-choice tests Fix spec test bigint type Fix typo in processAttestation flags Fix altair transition spec tests Fix altair transition tests Commit ViewDU changes in upgradeState Fix rebase issues
Codecov Report
@@ Coverage Diff @@
## master #3760 +/- ##
==========================================
- Coverage 36.25% 36.24% -0.01%
==========================================
Files 328 327 -1
Lines 9142 9094 -48
Branches 1438 1429 -9
==========================================
- Hits 3314 3296 -18
+ Misses 5682 5655 -27
+ Partials 146 143 -3 |
Closed
dapplion
commented
Feb 15, 2022
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
dapplion
commented
Apr 4, 2022
yarn.lock
Outdated
| @@ -505,6 +525,15 @@ | |||
| buffer-from "^1.1.1" | |||
| snappy "^6.3.5" | |||
|
|
|||
| "@chainsafe/ssz@^0.8.20": | |||
There was a problem hiding this comment.
Warning, this should not be in the yarn.lock. Who is depending in the old versions?
wemeetagain
approved these changes
Apr 4, 2022
Closed
This was referenced Apr 26, 2022
This was referenced May 10, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft note
This PR installs a placeholder version of SSZ with this awesome tool https://gitpkg.vercel.app/. This PR is open now to proof that Lodestar can run with this new SSZ version before releasing it.
lodestar/packages/api/package.json
Lines 43 to 44 in d719729
Motivation
Lodestar has implemented many optimizations around our data-structures. This PR together with ChainSafe/ssz#223 upstreams them to ssz.
See ChainSafe/ssz#223 for full rationale
Description
TODO After merging
ssz.Root.equals, use local bytesEqual utilities Use byteArrayEquals instead of ssz.Root.Equals #3996Closes #2859
Closes #2419
Closes #2408
Closes #3082
Closes #2966
Closes #3080