-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove redundant eventstream error listener #5798
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Jul 24, 2023
🎉 This PR is included in v1.10.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Noticed that after changes done in #5795 the error listener will always be called after socket close listener. This means that calling reject will not do anything as promise is already resolved.
As per my understanding, it was redundant before as well because the only error it would report is
ECONNRESET
if client disconnects which we don't want to log on the server (see previous PR #5722).These two PRs on node further indicate that the only error event that is emitted is due to client disconnect (
ECONNRESET
)'aborted'
IncomingMessage should'error'
nodejs/node#33172If there are actual error trying to write an event to the stream on the server, it would be caught by this
lodestar/packages/api/src/beacon/server/events.ts
Lines 42 to 44 in 7f19831
The server is not really concerned about anything else than writing data, if there is an error it must be detected by the client which is what we are doing already.
Invalid json data sent would be detected here
lodestar/packages/api/src/beacon/client/events.ts
Lines 25 to 28 in ec0a60f
and any other errors are caught here and reported here
lodestar/packages/api/src/beacon/client/events.ts
Lines 34 to 42 in ec0a60f
Description
Remove redundant eventstream error listener on the server.