-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mesh peers - inclusion and churn sum by reason metrics #5918
Merged
wemeetagain
merged 2 commits into
unstable
from
tuyen/fix_inclusion_churn_by_reason_metrics
Aug 29, 2023
Merged
fix: mesh peers - inclusion and churn sum by reason metrics #5918
wemeetagain
merged 2 commits into
unstable
from
tuyen/fix_inclusion_churn_by_reason_metrics
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
approved these changes
Aug 29, 2023
wemeetagain
approved these changes
Aug 29, 2023
🎉 This PR is included in v1.12.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Due to ChainSafe/js-libp2p-gossipsub#460, the way to track mesh inclusion/churn are different so the respective Grafana panel shows no data
Description
There is no
gossipsub_mesh_peer_inclusion_events_total
metric, we usegossipsub_mesh_peer_inclusion_events_${reason}_total
metric instead