Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomePlug AV broadcasts missing data #72

Open
Andgun98 opened this issue Aug 23, 2024 · 3 comments
Open

HomePlug AV broadcasts missing data #72

Andgun98 opened this issue Aug 23, 2024 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@Andgun98
Copy link

Hi,

I was troubleshooting some low level issues in an ISO session which turned out to be caused by a frequency offset problem.
This made me notice that this V2G plugin does not decode all of the HomePlug AV broadcast data. I'll add screenshots of the same pcap decoded with a different plugin in comparison to this one.

image
image

Just an idea for improving the capabilities of this plugin

@JeremyWhaling
Copy link
Contributor

As far as I know, this dissector doesn't handle HomePlug AV packets, these are handled by a dissector bundled with Wireshark. Can you state what other plug in you used? Also, a PCAP would help (truncated to just SLAC phase would be fine).

@ghost
Copy link

ghost commented Sep 4, 2024

@JeremyWhaling is correct, this plugin doesn't have any code to dissect HomePlug AV packets and uses the built-in Wireshark dissector. As always, if a better implementation is provided or a better library is available, we accept patches.

@ghost ghost added the help wanted Extra attention is needed label Sep 4, 2024
@barsnick
Copy link

Which Wireshark version and which plugins are you using?

My Qualcomm docs say this is a "VS_LNK_STATS_CNF", and there exists no "VS_GET_STATUS_CNF", but perhaps this packet is from a different vendor.

From looking at the code, Wireshark upstream supports this MME as HOMEPLUG_AV_MMTYPE_QUALCOMM_LNK_STATS_CNF ("LNK_STATS.CNF (Link Statistics Confirmation)") since v2.9.0:

https://gitlab.com/wireshark/wireshark/-/blob/master/epan/dissectors/packet-homeplug-av.c?ref_type=heads#L1007

That does look different from what both of your Wireshark screenshots show.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants