-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Original dates for observed days #58
Comments
hi @jbroudou, This is certainly an interesting idea! I think it's something we could probably add to the spec. We already have the currently unused So one way we could handle your suggestion would by be using that... we could have:
Without adding anything to the spec. Alternatively, if you wanted them to actually be linked, I think it would be something like:
Maybe? What's your use case? |
Hi @kaoru Although it would require changing the spec, I think the link method is explicit and would be less prone to errors especially when you factor in non English translations. - public_holiday: true
date: '2017-01-01'
observed_date: '2017-01-02'
names:
en: New Year's Day regarding the second part of my question, as an example see https://www.industrialrelations.nsw.gov.au/public-holidays/public-holidays-in-nsw/
It seems like public_holiday could be used to identify if the original date is a holiday. |
When an observed day (i.e. holidays that are moved because they are on a weekend) is returned would it possible to return the original date as well?
Also, in some locations when a holiday falls on a weekend, it is moved to a weekday as an observed day. In some of these locations only the observed day is considered a holiday whereas in others both the observed and original days are considered holidays. This is an important distinction in some jurisdictions.
Is there any chance of supporting an additional flag against observed holidays that indicate the original day is or isn't a holiday?
The text was updated successfully, but these errors were encountered: