From 96fb6332058d1a8524b0a8e6600b6b7dc1754a1a Mon Sep 17 00:00:00 2001 From: Rasmus Karlsson Date: Sun, 3 Apr 2022 18:10:21 +0200 Subject: [PATCH 1/2] Use a static time for mock livestreamfails responses :) --- internal/resolvers/livestreamfails/clip_resolver_test.go | 4 ++-- internal/resolvers/livestreamfails/data_test.go | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/internal/resolvers/livestreamfails/clip_resolver_test.go b/internal/resolvers/livestreamfails/clip_resolver_test.go index 43e434a6..c5cbc232 100644 --- a/internal/resolvers/livestreamfails/clip_resolver_test.go +++ b/internal/resolvers/livestreamfails/clip_resolver_test.go @@ -120,14 +120,14 @@ func TestClipResolver(t *testing.T) { label: "normal", inputURL: utils.MustParseURL("https://livestreamfails.com/clip/123"), inputClipID: "123", - expectedBytes: []byte(`{"status":200,"thumbnail":"https://livestreamfails-image-prod.b-cdn.net/image/asd","tooltip":"%3Cdiv%20style=%22text-align:%20left%3B%22%3E%0A%0A%3Cb%3EClip%20Label%3C%2Fb%3E%3Chr%3E%0A%3Cb%3EStreamer:%3C%2Fb%3E%20Streamer%20Label%3Cbr%3E%0A%3Cb%3ECategory:%3C%2Fb%3E%20Category%20Label%3Cbr%3E%0A%3Cb%3EPlatform:%3C%2Fb%3E%20Twitch%3Cbr%3E%0A%3Cb%3EReddit%20score:%3C%2Fb%3E%2069%3Cbr%3E%0A%3Cb%3ECreated:%3C%2Fb%3E%2027%20Mar%202022%0A%3C%2Fdiv%3E"}`), + expectedBytes: []byte(`{"status":200,"thumbnail":"https://livestreamfails-image-prod.b-cdn.net/image/asd","tooltip":"%3Cdiv%20style=%22text-align:%20left%3B%22%3E%0A%0A%3Cb%3EClip%20Label%3C%2Fb%3E%3Chr%3E%0A%3Cb%3EStreamer:%3C%2Fb%3E%20Streamer%20Label%3Cbr%3E%0A%3Cb%3ECategory:%3C%2Fb%3E%20Category%20Label%3Cbr%3E%0A%3Cb%3EPlatform:%3C%2Fb%3E%20Twitch%3Cbr%3E%0A%3Cb%3EReddit%20score:%3C%2Fb%3E%2069%3Cbr%3E%0A%3Cb%3ECreated:%3C%2Fb%3E%2010%20Nov%202019%0A%3C%2Fdiv%3E"}`), expectedError: nil, }, { label: "normal NSFW", inputURL: utils.MustParseURL("https://livestreamfails.com/clip/905"), inputClipID: "905", - expectedBytes: []byte(`{"status":200,"tooltip":"%3Cdiv%20style=%22text-align:%20left%3B%22%3E%0A%3Cli%3E%3Cb%3E%3Cspan%20style=%22color:%20red%22%3ENSFW%3C%2Fspan%3E%3C%2Fb%3E%3C%2Fli%3E%0A%3Cb%3EClip%20Label%3C%2Fb%3E%3Chr%3E%0A%3Cb%3EStreamer:%3C%2Fb%3E%20Streamer%20Label%3Cbr%3E%0A%3Cb%3ECategory:%3C%2Fb%3E%20Category%20Label%3Cbr%3E%0A%3Cb%3EPlatform:%3C%2Fb%3E%20Twitch%3Cbr%3E%0A%3Cb%3EReddit%20score:%3C%2Fb%3E%2069%3Cbr%3E%0A%3Cb%3ECreated:%3C%2Fb%3E%2027%20Mar%202022%0A%3C%2Fdiv%3E"}`), + expectedBytes: []byte(`{"status":200,"tooltip":"%3Cdiv%20style=%22text-align:%20left%3B%22%3E%0A%3Cli%3E%3Cb%3E%3Cspan%20style=%22color:%20red%22%3ENSFW%3C%2Fspan%3E%3C%2Fb%3E%3C%2Fli%3E%0A%3Cb%3EClip%20Label%3C%2Fb%3E%3Chr%3E%0A%3Cb%3EStreamer:%3C%2Fb%3E%20Streamer%20Label%3Cbr%3E%0A%3Cb%3ECategory:%3C%2Fb%3E%20Category%20Label%3Cbr%3E%0A%3Cb%3EPlatform:%3C%2Fb%3E%20Twitch%3Cbr%3E%0A%3Cb%3EReddit%20score:%3C%2Fb%3E%2069%3Cbr%3E%0A%3Cb%3ECreated:%3C%2Fb%3E%2010%20Nov%202019%0A%3C%2Fdiv%3E"}`), expectedError: nil, }, { diff --git a/internal/resolvers/livestreamfails/data_test.go b/internal/resolvers/livestreamfails/data_test.go index ab2b08c5..aa5814ca 100644 --- a/internal/resolvers/livestreamfails/data_test.go +++ b/internal/resolvers/livestreamfails/data_test.go @@ -14,12 +14,13 @@ var ( ) func init() { + testTime := time.Date(2019, time.November, 10, 23, 0, 0, 0, time.UTC) // Normal clip data["123"] = &ClipAPIResponse{ Category: ClipAPICategory{ Label: "Category Label", }, - CreatedAt: time.Now(), + CreatedAt: testTime, ImageID: "asd", IsNSFW: false, Label: "Clip Label", @@ -35,7 +36,7 @@ func init() { Category: ClipAPICategory{ Label: "Category Label", }, - CreatedAt: time.Now(), + CreatedAt: testTime, ImageID: "asd", IsNSFW: true, Label: "Clip Label", From 82b6444a6a4813a4b326580f55950fc8da107c80 Mon Sep 17 00:00:00 2001 From: Rasmus Karlsson Date: Sun, 3 Apr 2022 18:11:03 +0200 Subject: [PATCH 2/2] Update changelog entry --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 98c5dcc3..aae90de7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,7 +17,7 @@ - Dev: Improve Twitter tests. (#293) - Dev: Improve SevenTV tests. (#294) - Dev: Improve FrankerFaceZ tests. (#295) -- Dev: Improve Livestreamfails tests. (#297) +- Dev: Improve Livestreamfails tests. (#297, #301) ## 1.2.3