Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent nightly changes message layout padding #4838

Closed
4 tasks done
RandomGOTI opened this issue Sep 23, 2023 · 1 comment · Fixed by #4839
Closed
4 tasks done

Recent nightly changes message layout padding #4838

RandomGOTI opened this issue Sep 23, 2023 · 1 comment · Fixed by #4839
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user

Comments

@RandomGOTI
Copy link

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

The previous nightly had the message layout more compact and cleaner apperance , same config file without any changes between versions
For example a screenshot of live tab :
Chatterino Nightly 2.4.5 (commit 89b915ba) built on 2023-09-18 with Qt 5.15.2, MSVC 193532217
Running on Windows 7 Version 6.1 (Build 7601: SP 1), kernel: 6.1.7601
1
^ would fit 4 more lines compared to current

Chatterino Nightly 2.4.5 (commit 6860c700) built on 2023-09-23 with Qt 5.15.2, MSVC 193532217
Running on Windows 7 Version 6.1 (Build 7601: SP 1), kernel: 6.1.7601
2

Screenshots

No response

OS and Chatterino Version

Chatterino Nightly 2.4.5 (commit 6860c70) built on 2023-09-23 with Qt 5.15.2, MSVC 193532217 Running on Windows 7 Version 6.1 (Build 7601: SP 1), kernel: 6.1.7601
@RandomGOTI RandomGOTI added the issue-report An issue reported by a user. label Sep 23, 2023
@Mm2PL Mm2PL changed the title Recent nightly message layout changes Recent nightly changes padding Sep 23, 2023
@Mm2PL Mm2PL changed the title Recent nightly changes padding Recent nightly changes message layout padding Sep 23, 2023
@pajlada pajlada added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user and removed issue-report An issue reported by a user. labels Sep 23, 2023
@pajlada pajlada mentioned this issue Sep 23, 2023
Merged
pajlada added a commit that referenced this issue Sep 23, 2023
@pajlada
fix: margin change
4bb4812 
order of the QMargins class differed from the old custom Margins class

Fixes #4838
@pajlada
Copy link
Member

pajlada commented Sep 23, 2023

thanks for the keen 👁️ and quick report! Will be fixed by #4839

pajlada added a commit that referenced this issue Sep 23, 2023
@pajlada
fix: double margin (#4839)
06eb30a 
order of the QMargins class differed from the old custom Margins class

Fixes #4838
Nerixyz pushed a commit to SevenTV/chatterino7 that referenced this issue Sep 28, 2023
@pajlada @Nerixyz
fix: double margin (Chatterino#4839)
ed4abd0 
order of the QMargins class differed from the old custom Margins class

Fixes Chatterino#4838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: double margin Chatterino/chatterino2
2 participants
@pajlada @RandomGOTI