Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show follower emotes outside of channel if you're a subscriber #4281

Closed
wants to merge 11 commits into from
Closed

Show follower emotes outside of channel if you're a subscriber #4281

wants to merge 11 commits into from

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Jan 1, 2023 •
edited
Loading

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2023

clang-tidy review says "All clean, LGTM! 👍"

@pajlada pajlada force-pushed the feat/use-follower-emotes-outside-of-channel-if-you-are-a-subscriber branch from df17947 to 733ae24 Compare January 7, 2023 13:07
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

4 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@pajlada pajlada force-pushed the feat/use-follower-emotes-outside-of-channel-if-you-are-a-subscriber branch from 0bdaf28 to 41d3139 Compare January 8, 2023 12:28
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@pajlada pajlada force-pushed the feat/use-follower-emotes-outside-of-channel-if-you-are-a-subscriber branch from 41d3139 to e47b675 Compare January 8, 2023 13:33
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@pajlada pajlada force-pushed the feat/use-follower-emotes-outside-of-channel-if-you-are-a-subscriber branch from fe70ffd to 1bf4341 Compare January 14, 2023 11:28
@Felanbird Felanbird linked an issue Jan 14, 2023 that may be closed by this pull request
Update Follower Emote Handling #4233
Closed
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Wissididom
Wissididom reviewed Jan 14, 2023
View reviewed changes
src/controllers/ignores/IgnorePhrase.hpp
@@ -44,6 +44,9 @@ class IgnorePhrase

const std::unordered_map<EmoteName, EmotePtr> &getEmotes() const;

/**
* @brief containsEmote returns true if the ignored phrase replacement string contains a Twitch emotes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there it should either be contains Twitch emotes or contains a Twitch emote because it seems like it is mixed singular and plural.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@pajlada pajlada force-pushed the feat/use-follower-emotes-outside-of-channel-if-you-are-a-subscriber branch from c26d0eb to 99d2ce1 Compare January 15, 2023 11:49
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@pajlada pajlada force-pushed the feat/use-follower-emotes-outside-of-channel-if-you-are-a-subscriber branch from f4c71da to 920b997 Compare January 16, 2023 08:20
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@pajlada pajlada force-pushed the feat/use-follower-emotes-outside-of-channel-if-you-are-a-subscriber branch from 920b997 to b44e308 Compare January 22, 2023 07:59
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@giff-h
Copy link

giff-h commented Apr 14, 2023

Is this draft dead or abandoned, or just stale? I don't know C++ so I can't personally help, so I'm just giving this a bump.

@Felanbird
Copy link
Collaborator

Felanbird commented Apr 14, 2023 •
edited
Loading

It's stale because he's been very busy and this code sucks is a pain, so we need someone who actually codes C++ to give it the push it needs.

@baines baines mentioned this pull request Oct 28, 2023
Merged
@Felanbird
Copy link
Collaborator

Superseded by #4922

@Felanbird Felanbird closed this Nov 4, 2023
@Felanbird Felanbird deleted the feat/use-follower-emotes-outside-of-channel-if-you-are-a-subscriber branch December 19, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wissididom Wissididom Wissididom left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Follower Emote Handling
4 participants
@pajlada @giff-h @Felanbird @Wissididom