fix: update user-facing emote picker labels to use "7TV" naming #4405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't feel like this needs a changelog entry. Nobody will get excited about a label change. |
jupjohn
changed the title
Felanbird
approved these changes
Feb 24, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
This PR aims to update the label for 7TV emotes that is shown to users when searching for emotes in the emote picker. When browsing emotes, the section's label uses the
7TVname; however, when searching for emotes in the same popup window, the nameSevenTVwas used.As suggested by the 7TV crew (I believe Anatole was the one who we had this convo with), any user-facing branding should use the name
7TV. Only code should reference the nameSevenTVThanks for finding it Malachi :)