Support Animated FFZ Emotes and Authors for Global Emotes #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pajlada
requested changes
Mar 5, 2023
There was a problem hiding this comment.
For simplicity in reviewing, could you rebase the animated URL check into a separate commit from the refactors? Moving code (into a function in this case) & changing something in that function hides the functional changes that were made
not feedback, just notes for myself:
dev: This changes a bunch of toObject().value(...) calls to [...]. For QJsonValue's they do the same thing
dev: This changes a few value(...) calls to [...]. For QJsonObject's, they do the same thing
EDIT: I see you explaine dth evalue/operator[] stuff but I didn't read it :tf:
Nerixyz
force-pushed
the
feat/ffz-animated
branch
from
fd014f7 to
e2e1e05
Compare
pajlada
approved these changes
Mar 18, 2023
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
This PR adds support for animated FFZ emotes and shows authors for global emotes:
chatterino_2023-03-05_11-24-21.mp4
I refactored the code a bit to reduce duplicated parsing of channel/global emotes and to make it easier to read (by replacing
QJsonObject::valuewithQJsonObject::operator[]).