Store Themes as JSON files #4471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pajlada
approved these changes
Apr 8, 2023
There was a problem hiding this comment.
Dark theme differences
| old | new |
|---|---|
 |
 |
This has to do with some ancient ifdefs https://github.com/Chatterino/chatterino2/blame/8064f8a49ebf72e9332c0208e3b5b9d54bf3ec4c/lib/appbase/BaseTheme.cpp#L65-L69
I'm ok to concede the window background color so it's the same on Windows & MacOS, but changed on Linux (for now).
LGTM 👍
Thank you
|
I'm also not super fond of the macro solution but I understand there would be some string duplication without it, so I'm fine to leave that to some potential cleanup PR in the future. |
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
This PR removes the manual theme creation and adds theme parsing from JSON (as mentioned in #4447 (comment), JSON is probably the best format for this). I converted the built-in themes to JSON files that are included in the final executable. The colors are ported 1:1, so there shouldn't be any visual difference. To keep the parsing code small, I'm using a macro that ensures the JSON keys are the same as the C++ property names.
This is working towards #2237. You can already specify custom themes in the settings, but there's neither UI nor auto-reloading nor a wiki entry for it.