Fix channel search when custom scrollback limit is used #4496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornes
force-pushed
the
fix_channel-msg-limit
branch
from
2fe1fb7 to
1240417
Compare
|
I knew I wasn't crazy! Does this PR also fix user card message history? It looks like it should. |
|
usercards were also affected by this bug so #4324 was no delusion :D i spent some time looking for side effects and tested everything i planned, found no issues so PR is ready for review |
pajlada
approved these changes
Apr 1, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
PR introduces 2 changes:
Channelmessages_ field is initialized toscrollbackSplitLimitsetting, so it doesnt use default value of 1000.All code using Channel::getMessageSnapshot() was affected as it returned only up to 1k messages, while
ChannelViewrespected custom scrollback setting, so it created at least few problems.Example: https://i.supa.codes/Fn6J8.mp4 text selection would move up on each new message instead of holding its position.
scrollbackSplitLimitfor SearchPopup channelView, so all messages for single channel are always searchable.fixes #4495
Fixes #4324