Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages when updater fails a download #4594

Merged
merged 12 commits into from
May 2, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented May 2, 2023

Description

Context: SevenTV#219.

  • Downloads from the updater now follow redirects.
  • A dialog is shown when the HTTP status isn't 200.
  • Dialogs are simplified.

(I couldn't think of a good title)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/common/NetworkRequest.cpp Show resolved Hide resolved
src/common/NetworkRequest.cpp Show resolved Hide resolved
src/singletons/Updates.cpp Outdated Show resolved Hide resolved
src/singletons/Updates.cpp Outdated Show resolved Hide resolved
src/common/NetworkRequest.hpp Outdated Show resolved Hide resolved
src/singletons/Updates.cpp Outdated Show resolved Hide resolved
src/singletons/Updates.cpp Outdated Show resolved Hide resolved
src/singletons/Updates.cpp Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@pajlada pajlada changed the title Refactor Updates Improve error messages when updater fails a download May 2, 2023
@pajlada pajlada enabled auto-merge (squash) May 2, 2023 21:10
@pajlada pajlada merged commit bcd8028 into Chatterino:master May 2, 2023
@Nerixyz Nerixyz deleted the fix/updater branch October 6, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants