Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lib/crashpad from ec99257 to 432ff49 #4688

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 16, 2023

Bumps lib/crashpad from ec99257 to 432ff49.

Commits
  • 432ff49 Merge pull request #87 from getsentry/feat/crashpad_curl_response_body_log
  • 825cec1 feat: add response body to error log...
  • 514169d Merge pull request #85 from xyz1001/getsentry
  • 3cdef1c Merge pull request #86 from supervacuus/feat/handler_http_proxy_support
  • 7041349 Return the request success state
  • f72392e Fall back on deprecated NSURLConnection when not using an HTTP-proxy.
  • fb12516 Make sure that iOS doesn't use the proxy.
  • 98412e9 Add --http-proxy to run_with_crashpad tool
  • e29852c Make the ios-build happy about the proxy-settings.
  • af58387 Make sure dispatch_semaphore_signal is called when request errors
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [lib/crashpad](https://github.com/getsentry/crashpad) from `ec99257` to `432ff49`.
- [Commits](getsentry/crashpad@ec99257...432ff49)

---
updated-dependencies:
- dependency-name: lib/crashpad
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added ci Issues related to the ci submodules Issues related to updating submodules with dependabot labels Jun 16, 2023
Copy link
Contributor

@Nerixyz Nerixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A http_proxy argument was added to StartHandler in getsentry/crashpad@dc77935. Since Chatterino doesn't use the HTTP upload, this can be left empty:

diff --git a/src/providers/Crashpad.cpp b/src/providers/Crashpad.cpp
index 4c2fb976..f81cbe07 100644
--- a/src/providers/Crashpad.cpp
+++ b/src/providers/Crashpad.cpp
@@ -79,8 +79,8 @@ std::unique_ptr<crashpad::CrashpadClient> installCrashHandler()
 
     // See https://chromium.googlesource.com/crashpad/crashpad/+/HEAD/handler/crashpad_handler.md
     // for documentation on available options.
-    if (!client->StartHandler(handlerPath, databaseDir, {}, {}, {}, {}, true,
-                              false))
+    if (!client->StartHandler(handlerPath, databaseDir, {}, {}, {}, {}, {},
+                              true, false))
     {
         qCDebug(chatterinoApp) << "Failed to start crashpad handler";
         return nullptr;

Co-authored-by: nerix <nerixdev@outlook.de>
@pajlada pajlada merged commit 36bc8e0 into master Jun 16, 2023
@pajlada pajlada deleted the dependabot/submodules/lib/crashpad-432ff49 branch June 16, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues related to the ci submodules Issues related to updating submodules with dependabot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants