Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force shortcuts to show in context menus on macOS #4722

Merged
merged 4 commits into from
Jul 22, 2023

Conversation

Mm2PL
Copy link
Collaborator

@Mm2PL Mm2PL commented Jul 14, 2023

Description

Hopefully fix #4657? Now shortcuts should be shown on every platform.

Fixes #4657

@Mm2PL Mm2PL requested a review from pajlada July 14, 2023 12:01
@pajlada
Copy link
Member

pajlada commented Jul 22, 2023

Does not make a difference for me on my mac mini m2, running Ventura 13.4

@pajlada
Copy link
Member

pajlada commented Jul 22, 2023

Nevermind, the shortcuts do show.
Should the code be run on macOS only?

@Mm2PL
Copy link
Collaborator Author

Mm2PL commented Jul 22, 2023

Should the code be run on macOS only?

It shouldn't matter, the property should be set to this on other OSes anyway. If any oses decide to change this, c2 will always show shortcuts

@pajlada pajlada changed the title Force shortcuts to show in context menus Force shortcuts to show in context menus on macOS Jul 22, 2023
@pajlada pajlada enabled auto-merge (squash) July 22, 2023 10:58
@pajlada pajlada merged commit 0e83367 into master Jul 22, 2023
@pajlada pajlada deleted the bugfix/try_force_setting_ShowShortcutsInContextMenus branch July 22, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu shortcut indicators don't show on Mac
2 participants