Add support for opening links in incognito mode on Linux & BSD #4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- whitespace - use this explicitly - underscore prefix on private members
Felanbird
reviewed
Aug 2, 2023
- don't use .leftRef/.splitRef - use QStringView where applicable
sheybey
force-pushed
the
linux-open-incognito
branch
from
ca93b88 to
c1b7258
Compare
add Qt.hpp helper include to XDGDirectory.cpp
before this change, this ::mid call would have resulted in undefined behavior when running under Qt older than 5.15 on a key with an empty value (equals sign at the end of the line)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
# Conflicts: # CHANGELOG.md
pajlada
reviewed
Aug 5, 2023
xdg-settings took around ~130ms to run on my system, whereas the mimapps solution took ~0.5ms
pajlada
approved these changes
Aug 6, 2023
There was a problem hiding this comment.
Works as expected for me now. If you can think of some other tests, please add them.
Please also read through the commits I've done and see if there's anything I've misunderstood
When you're happy to have this merged in, let us know and we'll hit the merge button
- paths with spaces in them - paths with characters reserved by spec
Done and done. Looks good to me |
pajlada
changed the title
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 12, 2023
…erino#4745) Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 19, 2023
…erino#4745) Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for opening links in private/incognito mode under Linux/BSD when using a desktop environment that follows the freedesktop specification. See #4366
List of technical changes
ego check (add myself to contributors.txt)Discussion points
I originally thought that you could read desktop files, which are essentially .ini files, with QSettings. However, the default app database (which is a desktop file) uses mimetypes as key names, which is incompatible with QSettings as the key may include
/. I wrote a parser for them which didn't end up bigger than the code consuming it, so I feel comfortable still not adding another dependency for this. That being said, it should probably get as many eyes on it as possible since it is still a home-rolled parser.Some other points I would appreciate opinions on:
getDefaultBrowserExecutableis called twice per settings open. Is a big search like this PR adds worth caching?I've tested this under Windows (for the minor behavior change) and under Debian testing with gnome. Throw your hairiest setups at this and let me know if anything breaks.