Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race in PubSub #4771

Merged
merged 2 commits into from
Aug 27, 2023
Merged

Fix data race in PubSub #4771

merged 2 commits into from
Aug 27, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Aug 19, 2023

Description

This ensures the close call is posted to the io_service executor
This fixes a data race with the get_con_from_hdl function

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/singletons/Settings.cpp Outdated Show resolved Hide resolved
src/singletons/Settings.cpp Outdated Show resolved Hide resolved
src/singletons/Settings.cpp Outdated Show resolved Hide resolved
src/singletons/Settings.cpp Outdated Show resolved Hide resolved
src/singletons/Settings.cpp Outdated Show resolved Hide resolved
tests/src/SeventvEventAPI.cpp Outdated Show resolved Hide resolved
tests/src/SeventvEventAPI.cpp Outdated Show resolved Hide resolved
tests/src/TwitchPubSubClient.cpp Outdated Show resolved Hide resolved
tests/src/TwitchPubSubClient.cpp Outdated Show resolved Hide resolved
tests/src/TwitchPubSubClient.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

tests/src/InputCompletion.cpp Outdated Show resolved Hide resolved
@pajlada pajlada force-pushed the fix/chase-data-races branch 7 times, most recently from e93851f to eac7135 Compare August 20, 2023 10:11
@pajlada pajlada changed the title Big boy PR doing some refactors that should be cherry-picked before being merged into anything Fix data race in PubSub Aug 20, 2023
@pajlada pajlada added this to the Post 2.4.5 milestone Aug 20, 2023
@pajlada pajlada self-assigned this Aug 20, 2023
@pajlada pajlada marked this pull request as ready for review August 20, 2023 10:14
@pajlada pajlada force-pushed the fix/chase-data-races branch from eac7135 to d776f08 Compare August 27, 2023 20:42
@pajlada
Copy link
Member Author

pajlada commented Aug 27, 2023

image

@pajlada pajlada enabled auto-merge (squash) August 27, 2023 20:45
@pajlada pajlada merged commit 4c942a2 into master Aug 27, 2023
@pajlada pajlada deleted the fix/chase-data-races branch August 27, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant