Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Image & Image's Frames #4773

Merged
merged 7 commits into from
Sep 13, 2023
Merged

Refactor Image & Image's Frames #4773

merged 7 commits into from
Sep 13, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Aug 20, 2023

  • Image.cpp: Change boost::optional to std::optional
  • Image.cpp: use empty() instead of size() == 0
  • Image.cpp: don't use else after a return
  • Image.cpp: be a bit more mindful of how weak ptr is shared

Description

@pajlada pajlada added this to the Post 2.4.5 milestone Aug 20, 2023
@pajlada pajlada self-assigned this Aug 20, 2023
@pajlada pajlada changed the title Refactor Image.cpp Refactor Image & Image's Frames Sep 13, 2023
@pajlada pajlada enabled auto-merge (squash) September 13, 2023 18:33
@pajlada pajlada merged commit 9ca2578 into master Sep 13, 2023
16 checks passed
@pajlada pajlada deleted the chore/refactor-image branch September 13, 2023 19:26
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pajlada pajlada

Labels
None yet
Projects
None yet
Milestone
Post 2.4.5
Development

Successfully merging this pull request may close these issues.
1 participant
@pajlada