Fix input completion tests on Qt6 & run tests on 22.04 #4774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is achieved by not checking exact order for certain completion tests
This allows us to be a bit more loose and use more C++20 features in tests
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -224,6 +226,25 @@ class InputCompletionTest : public ::testing::Test | |||
| } | |||
| }; | |||
|
|
|||
| void containsRoughly(std::span<detail::CompletionEmote> span, | |||
| std::set<QString> values) | |||
There was a problem hiding this comment.
warning: the parameter 'values' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Suggested change
| std::set<QString> values) | |
| const std::set<QString>& values) |
pajlada
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is achieved by not checking exact order for certain completion tests
GitHub actions now run all tests in Ubuntu 22.04 - this is done to be able to use more modern features in tests
We will still support Ubuntu 20.04 in the actual main project
Update dockerfiles to match this new reality