Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Windows helpers #4820

Merged
merged 4 commits into from
Sep 17, 2023
Merged

Cleanup Windows helpers #4820

merged 4 commits into from
Sep 17, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Sep 16, 2023

Description

This fixes an issue where OleFlushClipboard was called when not owning the clipboard (causes an exception) and cleans up the WindowsHelper code. I was too scared to make the change from GetDpiForMonitor to GetDpiForWindow (which is the preferred API), so I added a TODO.

@pajlada pajlada enabled auto-merge (squash) September 17, 2023 09:25
@pajlada pajlada merged commit f13a3b9 into Chatterino:master Sep 17, 2023
17 checks passed
@Nerixyz Nerixyz deleted the fix/windows-exception branch September 17, 2023 10:27
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
no changelog entry needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nerixyz @pajlada @Felanbird