Add some more filter tests #4897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }; | ||
|
|
||
| // clang-format off | ||
| std::vector<TestCase> tests{ |
There was a problem hiding this comment.
warning: variable 'tests' of type 'std::vector' can be declared 'const' [misc-const-correctness]
Suggested change
| std::vector<TestCase> tests{ | |
| std::vector<TestCase> const tests{ |
Nerixyz
reviewed
Oct 14, 2023
| EXCLUDE "/usr/include/*" | ||
| EXCLUDE "build-*/*" | ||
| EXCLUDE "lib/*" | ||
| EXCLUDE "*/ui_*.h" | ||
| EXCLUDE "*/moc_*.cpp" |
There was a problem hiding this comment.
Should also exclude */*.moc.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the
make coveragefunction to usegcovrinstead oflcov, and to have it generate an html file directly atcoverage/index.htmlunder the build directoryThe only thing this changes, other than adding tests, is making the
Expressionclass pure virtual. Every derived class should implement each of the functions