Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add VERSIONINFO resource for windows #4912

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

kornes
Copy link
Contributor

@kornes kornes commented Oct 21, 2023

PR adds auto generation of versioninfo resource for windows builds

results of (Get-Item .\chatterino.exe).VersionInfo|Select *:

Before After
FileVersionRaw : 0.0.0.0
ProductVersionRaw : 0.0.0.0
Comments :
CompanyName :
FileBuildPart : 0
FileDescription :
FileMajorPart : 0
FileMinorPart : 0
FileName : chatterino.exe
FilePrivatePart : 0
FileVersion :
InternalName :
IsDebug : False
IsPatched : False
IsPrivateBuild : False
IsPreRelease : False
IsSpecialBuild : False
Language :
LegalCopyright :
LegalTrademarks :
OriginalFilename :
PrivateBuild :
ProductBuildPart : 0
ProductMajorPart : 0
ProductMinorPart : 0
ProductName :
ProductPrivatePart : 0
ProductVersion :
SpecialBuild :
FileVersionRaw : 2.4.6.0
ProductVersionRaw : 2.4.6.0
Comments :
CompanyName : Chatterino, https://chatterino.com/
FileBuildPart : 6
FileDescription : Chatterino
FileMajorPart : 2
FileMinorPart : 4
FileName : chatterino.exe
FilePrivatePart : 0
FileVersion : 2.4.6
InternalName : Chatterino
IsDebug : False
IsPatched : False
IsPrivateBuild : False
IsPreRelease : False
IsSpecialBuild : True
Language : English (United States)
LegalCopyright : Project contributors 2016-2023
LegalTrademarks :
OriginalFilename : Chatterino
PrivateBuild :
ProductBuildPart : 6
ProductMajorPart : 2
ProductMinorPart : 4
ProductName : Chatterino
ProductPrivatePart : 0
ProductVersion : 2.4.6
SpecialBuild : 12808d3

cmake/resources/generate_resources.cmake Outdated Show resolved Hide resolved
cmake/resources/windows.rc.in Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
cmake/resources/windows.rc.in Outdated Show resolved Hide resolved
@kornes kornes force-pushed the feat/version-info-res branch from e95e606 to 72dc660 Compare November 3, 2023 15:32
@pajlada pajlada merged commit b3ed328 into Chatterino:master Nov 3, 2023
15 checks passed
@kornes kornes deleted the feat/version-info-res branch November 3, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants