-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use override instead of virtual where possible #4917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 30. Check the log or trigger a new build to see more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Description
This PR fixes most warnings from the clang-tidy
cppcoreguidelines-explicit-virtualfunctions
checkPart of #4915
Unrelated change(s)
Irc2: Add some newlines to let the anon namespace breathe
LambdaRunnable: Initialize action_ in member initializer list
IrcChannel: Made the class final
TwitchChannel: Made the class final
How to review
Most changes are just removing virtual & the reformatting that comes with it.
TwitchChannel had 3 virtual functions that were never overwritten,
refresh{BTTV,FFZ,SevenTV}ChannelEmotes
. I removed virtual complete there.Made
LambdaRunnable
'srun
function override - it was not override or virtual before, but run is most likely meant to overrideQRunnable
'srun
function.Made
GeneralPage
'sfilterElements
function overrideComboBoxItemDelegate
now uses override instead of virtual, since they override functions fromQStyledItemDelegate