From b7f0fdbc23c174a1590030399a8c2e288c475184 Mon Sep 17 00:00:00 2001 From: Rasmus Karlsson Date: Sat, 4 Nov 2023 13:55:24 +0100 Subject: [PATCH 1/2] Add a 10m timeout to the clang-tidy job --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 38321ab54bd..30870797852 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -331,6 +331,7 @@ jobs: - name: clang-tidy review if: matrix.clang-tidy-review && github.event_name == 'pull_request' + timeout-minutes: 10 uses: ZedThree/clang-tidy-review@v0.14.0 with: build_dir: build-clang-tidy From 273273b5646bd3cc11af5e67fc12a35b6a9b2799 Mon Sep 17 00:00:00 2001 From: Rasmus Karlsson Date: Sat, 4 Nov 2023 14:20:07 +0100 Subject: [PATCH 2/2] disable const-correctness analyzevalues --- .clang-tidy | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.clang-tidy b/.clang-tidy index 5d3a0d09ea3..658f661392a 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -63,3 +63,6 @@ CheckOptions: # Lua state - key: readability-identifier-naming.LocalPointerIgnoredRegexp value: ^L$ + + - key: misc-const-correctness.AnalyzeValues + value: false