refactor: Ignores and Replacements #4965
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the replacement of ignores. I noticed two additional bugs:
Kappa Keepo
→Keepo Kappa
wouldn't add emotesFixes #2617.
The limit for replacements is 128, if this is reached, the message will be replaced with:
Too many replacements - check your ignores!
I couldn't see a good use-case where these many iterations would make sense.
Additionally:
SizeType
to support both Qt 5 and 6 (this should be done for more stuff)mutable
sIt's a bit unfortunate that we still have
QRegularExpression emoteregex("\\b" + emote.name.string + "\\b", ..)
which will always be cold or at least needs to be compiled for every emote. Maybe we can useQChar::isSpace
there?